Update the AdminSet permissions when removing a PermissionTemplateAccess #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
requested changes
Mar 17, 2017
| # Calculate and update who should have edit access based on who | ||
| # has "manage" access in the PermissionTemplateAccess | ||
| def update_access_controls! | ||
| update!(edit_users: permission_template.access_grants.where(access: 'manage', agent_type: 'user').pluck(:agent_id), |
There was a problem hiding this comment.
Can you extract local variables for these two lines. They are rather long and hard to quickly parse.
new_edit_users = permission_template.access_grants.where(access: 'manage', agent_type: 'user').pluck(:agent_id)
new_edit_groups = permission_template.access_grants.where(access: 'manage', agent_type: 'group').pluck(:agent_id)
update!(edit_users: new_edit_users, edit_groups: new_edit_groups)
jeremyf
added a commit
that referenced
this pull request
Mar 17, 2017
There was a lot of external knowledge regarding the structure of the permission template. Instead, encapsulate that knowledge in a method on the permission template. Related to #584
jeremyf
added a commit
that referenced
this pull request
Mar 17, 2017
There was a lot of external knowledge regarding the structure of the permission template. Instead, encapsulate that knowledge in a method on the permission template. Related to #584
jeremyf
approved these changes
Mar 17, 2017
jeremyf
added a commit
that referenced
this pull request
Mar 17, 2017
There was a lot of external knowledge regarding the structure of the permission template. Instead, encapsulate that knowledge in a method on the permission template. Related to #584
jeremyf
added a commit
that referenced
this pull request
Mar 17, 2017
There was a lot of external knowledge regarding the structure of the permission template. Instead, encapsulate that knowledge in a method on the permission template. Related to #584
jeremyf
added a commit
that referenced
this pull request
Mar 20, 2017
There was a lot of external knowledge regarding the structure of the permission template. Instead, encapsulate that knowledge in a method on the permission template. Related to #584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570