Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting method to encapsulate where / pluck #586

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Mar 17, 2017

There was a lot of external knowledge regarding the structure of the
permission template. Instead, encapsulate that knowledge in a method
on the permission template.

Related to #584

@projecthydra-labs/hyrax-code-reviewers

@jcoyne
Copy link
Member

jcoyne commented Mar 17, 2017

Good idea. Needs a rebase.

@jeremyf jeremyf force-pushed the extracting-method branch from 3b46b73 to 5d457f4 Compare March 17, 2017 20:46
@mjgiarlo mjgiarlo added this to the 1.0.0 milestone Mar 17, 2017
@jcoyne
Copy link
Member

jcoyne commented Mar 17, 2017

Rebase...once again.

@jeremyf jeremyf force-pushed the extracting-method branch from 5d457f4 to 15de768 Compare March 17, 2017 20:58
There was a lot of external knowledge regarding the structure of the
permission template. Instead, encapsulate that knowledge in a method
on the permission template.

Related to #584
@jeremyf jeremyf force-pushed the extracting-method branch from 15de768 to d789f32 Compare March 20, 2017 12:49
@jeremyf jeremyf merged commit 5204917 into master Mar 20, 2017
@jeremyf jeremyf deleted the extracting-method branch March 20, 2017 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants