fix: enhance oauth/authorization UI #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying saitamau-maximum-auth with
|
| Latest commit: |
4b3e776
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a3121cf.saitamau-maximum-auth.pages.dev |
| Branch Preview URL: | https://feat-oauth-ui.saitamau-maximum-auth.pages.dev |
sor4chi
force-pushed
the
feat/oauth-ui
branch
2 times, most recently
from
8e82984 to
33aac0c
Compare
a01sa01to
reviewed
Nov 9, 2024
|
任せる |
sor4chi
force-pushed
the
feat/oauth-ui
branch
from
33aac0c to
4b3e776
Compare
a01sa01to
reviewed
Nov 9, 2024
次のPRで良い？今回は単に既存SSRのリファクタなので
これはそもそもoauth機能とaccount機能を一緒に置いてるのが悪くて、基本的に別システムなのでパッケージ or サービス分けるくらいにしたほうが良さそう |
これは作りながら思ったので分けましょうかね... |
a01sa01to
approved these changes
Nov 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.