Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth UI #24

Merged
merged 9 commits into from
Oct 27, 2024
Merged

feat: Auth UI #24

merged 9 commits into from
Oct 27, 2024

Conversation

sor4chi
Copy link
Member

@sor4chi sor4chi commented Oct 27, 2024

よく考えたら/continue以外作り替えなのでスタイリングする必要なかった

@sor4chi sor4chi requested a review from a01sa01to October 27, 2024 05:43
@sor4chi sor4chi self-assigned this Oct 27, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2024

Deploying saitamau-maximum-auth with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6585e0c
Status: ✅  Deploy successful!
Preview URL: https://3a752c7e.saitamau-maximum-auth.pages.dev
Branch Preview URL: https://feat-auth-ui.saitamau-maximum-auth.pages.dev

View logs

@a01sa01to
Copy link
Member

image

あれ おま環? + Lint をお願い

@a01sa01to
Copy link
Member

image

こっちはよさそう

webapp/app/components/ui/button-variant.tsx Outdated Show resolved Hide resolved
webapp/app/routes/continue/route.tsx Outdated Show resolved Hide resolved
webapp/panda.config.ts Outdated Show resolved Hide resolved
@sor4chi
Copy link
Member Author

sor4chi commented Oct 27, 2024

image

あれ おま環? + Lint をお願い

これどうせ後でスタイリングするしこのページアクセスされないからサボった、CSS書いた方がいい?

@sor4chi sor4chi requested a review from a01sa01to October 27, 2024 13:28
@a01sa01to
Copy link
Member

これどうせ後でスタイリングするしこのページアクセスされないからサボった、CSS書いた方がいい?

まあもしかしたらダイレクトアクセスあるかもなので一応あるとうれしい

@sor4chi
Copy link
Member Author

sor4chi commented Oct 27, 2024

あーこれwebappとrootどっちもにlint設定があるのか

Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#24 (comment)

や、こっちがまだなのか

@sor4chi
Copy link
Member Author

sor4chi commented Oct 27, 2024

Screenshot 2024-10-27 at 22 39 48
@a01sa01to
こんなんでいい?

@a01sa01to
Copy link
Member

よさそう

@sor4chi sor4chi requested a review from a01sa01to October 27, 2024 13:42
@sor4chi
Copy link
Member Author

sor4chi commented Oct 27, 2024

ん、デプロイ反映されてないのか?

@a01sa01to
Copy link
Member

Not Found もお願いしたい 🙏

@sor4chi
Copy link
Member Author

sor4chi commented Oct 27, 2024

Screenshot 2024-10-27 at 23 03 24

Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:eeyan:

@sor4chi sor4chi merged commit eea623b into main Oct 27, 2024
7 checks passed
@sor4chi sor4chi deleted the feat/auth-ui branch October 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants