-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rename the gcc component to gcc-dev #150535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Rename the gcc component to ci-gcc try-job: dist-x86_64-linux
|
perhaps it should be gcc-dev by analogy with rustc-dev? |
|
The "analogical" LLVM component is actually rust-dev, not rustc-dev (which shows how beautifully named are our components) 😆 But yeah, |
To free up the `gcc` name for the actual libgccjit component that we will ship to rustup, and also make it more explicit that this component is internal and for bootstrap usages only.
Because we renamed the CI component. We will have to re-enable it in a follow-up PR.
The `CiGcc` step is not enabled by defaut, so it does not have to be skipped.
|
Renamed it to |
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Rename the gcc component to gcc-dev try-job: dist-x86_64-linux
|
it would be funny to rename rust-dev to llvm-dev and rustc-dev to rustc-private, lol. download-ci-rustc doesn't have a dedicated component i don't think, it just reuses rustc-private. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup=never |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6885bdf (parent) -> 0d162b2 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0d162b25edd5bf0dba9a22e83b614f1113e90474 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (0d162b2): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.8%, secondary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.743s -> 474.733s (0.21%) |
|
Noise, this only renamed a CI component. @rustbot label: +perf-regression-triaged |
1 similar comment
|
Noise, this only renamed a CI component. @rustbot label: +perf-regression-triaged |
In preparation for https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Safe.20rustup.20distribution.20of.20rustc_codegen_gcc/with/565801325.
try-job: dist-x86_64-linux