Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 31, 2025

try-job: dist-x86_64-linux

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 31, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Dec 31, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Dec 31, 2025
Add a dist component for cg_gcc

try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@antoyo
Copy link
Contributor

antoyo commented Dec 31, 2025

You seem to be making changes to the dylibs stuff, so don't hesitate to ask me to test that this still works for cross-compiling rustc if you need me to.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Dec 31, 2025

💔 Test for 07629c3 failed: CI. Failed jobs:

@Kobzol
Copy link
Member Author

Kobzol commented Jan 2, 2026

I don't think my changes should affect the multi-target libgccjit dylib building, but if you can try, that would be helpful, of course :)

@bors try

rust-bors bot added a commit that referenced this pull request Jan 2, 2026
Add a dist component for cg_gcc

try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jan 2, 2026

☀️ Try build successful (CI)
Build commit: 09e4f11 (09e4f11d243b60bb64549da0285de0c149f80c9c, parent: 1b4325211c3228dd10eea12e9b3f749f87363d95)

@antoyo
Copy link
Contributor

antoyo commented Jan 2, 2026

I don't think my changes should affect the multi-target libgccjit dylib building, but if you can try, that would be helpful, of course :)

Ok. Please tell me when this is ready and I'll do the test locally.

@Kobzol
Copy link
Member Author

Kobzol commented Jan 2, 2026

It is ready now, just waiting for #150535 to be reviewed and merged.

@antoyo
Copy link
Contributor

antoyo commented Jan 2, 2026

It is ready now, just waiting for #150535 to be reviewed and merged.

I made my test and everything still seems to work.

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

☔ The latest upstream changes (presumably #150535) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-bors
Copy link

rust-bors bot commented Jan 5, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol Kobzol force-pushed the dist-cg-gcc-component branch from 39c1817 to 04707f4 Compare January 5, 2026 09:53
@Kobzol Kobzol marked this pull request as ready for review January 5, 2026 09:53
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol
Copy link
Member Author

Kobzol commented Jan 5, 2026

r? @jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned clubby789 Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants