Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle submodules automatically on doc steps #134967

Merged
merged 2 commits into from
Jan 2, 2025
Merged

handle submodules automatically on doc steps #134967

merged 2 commits into from
Jan 2, 2025
+40 −32

Conversation

onur-ozkan
Copy link
Member

Helps to make doc macros less complicated.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 31, 2024
jieyouxu
jieyouxu approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me after PR CI is green.

@onur-ozkan
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit 6eb9ebf has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#134967 - onur-ozkan:auto-submodule-handler,…
29d5e3d 
… r=jieyouxu

handle submodules automatically on `doc` steps

Helps to make `doc` macros less complicated.
This was referenced Jan 1, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2025
@bors
Auto merge of rust-lang#135005 - matthiaskrgr:rollup-5ubuitt, r=matth…
62b13a9 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134967 (handle submodules automatically on `doc` steps)
 - rust-lang#134973 (Fix typos)
 - rust-lang#134984 (`ObligationCause` construction tweaks in typeck)
 - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc)
 - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit afdb627 into rust-lang:master Jan 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
@rust-timer
Unrolled build for rust-lang#134967
b7594c1 
Rollup merge of rust-lang#134967 - onur-ozkan:auto-submodule-handler, r=jieyouxu

handle submodules automatically on `doc` steps

Helps to make `doc` macros less complicated.
@psumbera psumbera mentioned this pull request Jan 2, 2025
Closed
@onur-ozkan onur-ozkan deleted the auto-submodule-handler branch January 2, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @bors @jieyouxu @Kobzol