Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #135002

Closed
wants to merge 9 commits into from
Closed

Rollup of 4 pull requests #135002

wants to merge 9 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ericlehong and others added 9 commits December 31, 2024 12:33
@ericlehong
Fix typos
e34465f 
Signed-off-by: ericlehong <[email protected]>
@onur-ozkan
handle submodules automatically on doc steps
b1b576d 
Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
add test coverage for helpers::is_path_in_submodule
6eb9ebf 
Signed-off-by: onur-ozkan <[email protected]>
@compiler-errors
Obligation tweaks
1638948
@mgsloan
Remove qualification of std::cmp::Ordering in Ord doc
cdd55bf
@matthiaskrgr
Rollup merge of rust-lang#134967 - onur-ozkan:auto-submodule-handler,…
29d5e3d 
… r=jieyouxu

handle submodules automatically on `doc` steps

Helps to make `doc` macros less complicated.
@matthiaskrgr
Rollup merge of rust-lang#134973 - ericlehong:fix-typo, r=GuillaumeGomez
5b7619d 
Fix typos

This PR fixes typos errors in comments and docs.

Thank you very much.
@matthiaskrgr
Rollup merge of rust-lang#134984 - compiler-errors:obligation-tweaks,…
bd5f1ff 
… r=lqd

`ObligationCause` construction tweaks in typeck

Mostly just consolidating the way we construct obligations in `FnCtxt`.
@matthiaskrgr
Rollup merge of rust-lang#134985 - mgsloan:remove-unnecessary-qualifi…
294d501 
…cation-in-Ord-trait-docs, r=Noratrieb

Remove qualification of `std::cmp::Ordering` in `Ord` doc
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented Jan 1, 2025

📌 Commit 294d501 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rustbot @ericlehong @onur-ozkan @compiler-errors @mgsloan