Skip to content

Update get_processed_source to accept keyword arguments #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update get_processed_source to accept keyword arguments #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5762985
Update `get_processed_source` to accept keyword arguments
Rylan12 Aug 26, 2025
4d6c7e8
Allow other private extension methods to accept/pass along any arguments
Rylan12 Aug 26, 2025
a9bbf46
Use `...` instead of `*args, **kwargs` for argument forwarding
Rylan12 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ AllCops:
- '*.gemspec'
DisplayCopNames: true
StyleGuideCopsOnly: false
TargetRubyVersion: 2.6
SuggestExtensions: false

Style/Documentation:
Expand Down
10 changes: 5 additions & 5 deletions lib/rubocop/markdown/rubocop_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,21 @@ def markdown_file?(file)

RuboCop::Runner.prepend(Module.new do
# Set config store for Markdown
def get_processed_source(*args)
def get_processed_source(...)
RuboCop::Markdown.config_store = @config_store unless RuboCop::Markdown.config_store

super
end

# Do not cache markdown files, 'cause cache doesn't know about processing.
# NOTE: we should involve preprocessing in RuboCop::CachedData#deserialize_offenses
def file_offense_cache(file)
def file_offense_cache(file, ...)
return yield if RuboCop::Markdown.markdown_file?(file)

super
end

def file_finished(file, offenses)
def file_finished(file, offenses, ...)
return super unless RuboCop::Markdown.markdown_file?(file)

# Run Preprocess.restore if file has been autocorrected
Expand Down Expand Up @@ -75,14 +75,14 @@ def offenses

# Allow Rubocop to analyze markdown files
RuboCop::TargetFinder.prepend(Module.new do
def ruby_file?(file)
def ruby_file?(file, ...)
super || RuboCop::Markdown.markdown_file?(file)
end
end)

# Extend ProcessedSource#parse with pre-processing
RuboCop::ProcessedSource.prepend(Module.new do
def parse(src, *args)
def parse(src, ...)
# only process Markdown files
src = RuboCop::Markdown::Preprocess.new(path).call(src) if
path && RuboCop::Markdown.markdown_file?(path)
Expand Down