Update get_processed_source to accept keyword arguments
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
reviewed
Aug 26, 2025
|
I changed it over to a positional argument in order not to break this github.com/rubocop/rubocop/pull/14480. Still should be changed here as well though. |
|
Thanks for working on this. Looks good to go for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to rubocop/rubocop#14478
The
get_processed_sourcemethod has been updated to have aprism_result:keyword argument, so in this repo it must be modified to support passing keyword arguments along viasuper.I'm not sure how
rubocop-mdreleases align withrubocopreleases, but I think this change should be safe to be released independently of a newrubocoprelease as the change just enables keyword arguments but doesn't require them.