Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean COM wrappers leak: Round 2 #4491

Merged
merged 10 commits into from
Nov 18, 2018
Merged

Clean COM wrappers leak: Round 2 #4491

merged 10 commits into from
Nov 18, 2018

Commits on Nov 4, 2018

  1. Additional leaks plugged

    @bclothier
    bclothier committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    5539581 View commit details
    Browse the repository at this point in the history

  2. Add IDisposable Analyzer and assess its usefulness. Fix some legitima… 

    …te issues. Disable the analyzer due to numerous false positives.
    @bclothier
    bclothier committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    b03a59d View commit details
    Browse the repository at this point in the history

  3. Add missing Dispose for conditional returns.

    @bclothier
    bclothier committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    14665a3 View commit details
    Browse the repository at this point in the history

  4. Fix a failing unit test due to not passing in the mocked vbe object.

    @bclothier
    bclothier committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    9bfbca0 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Address PR comments 

    Revert changes to RegistryAccess and IndenterSettings -- registry work requires more thought than simply wrapping a new using block.
    @bclothier
    bclothier committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    84503b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Remove unneeded Dispose

    @bclothier
    bclothier committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    1d1b55a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i… 

    …nto CleanComSafeLeakRound2

# Conflicts:
#	Rubberduck.VBEditor.VBA/SafeComWrappers/Application/FallbackApp.cs
#	Rubberduck.VBEditor.VBA/SafeComWrappers/VB/VBE.cs
#	RubberduckTests/CodeExplorer/CodeExplorerTests.cs
    @bclothier
    bclothier committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    06ae0be View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i… 

    …nto CleanComSafeLeakRound2
    @bclothier
    bclothier committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    71034ff View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    @bclothier
    bclothier committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    869f783 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2018

  1. Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i… 

    …nto CleanComSafeLeakRound2

# Conflicts:
#	Rubberduck.CodeAnalysis/QuickFixes/IgnoreOnceQuickFix.cs
#	Rubberduck.Resources/Rubberduck.Resources.csproj
    @bclothier
    bclothier committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    599e852 View commit details
    Browse the repository at this point in the history