Clean COM wrappers leak: Round 2 #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te issues. Disable the analyzer due to numerous false positives.
comintern
reviewed
Nov 4, 2018
Rubberduck.Core/UI/Command/MenuItems/CommandBars/AppCommandBarBase.cs
Outdated
Show resolved
Hide resolved
Rubberduck.Core/UI/Command/MenuItems/ParentMenus/ParentMenuItemBase.cs
Outdated
Show resolved
Hide resolved
Rubberduck.Core/UI/UnitTesting/Commands/AddTestModuleCommand.cs
Outdated
Show resolved
Hide resolved
Revert changes to RegistryAccess and IndenterSettings -- registry work requires more thought than simply wrapping a new using block.
comintern
reviewed
Nov 5, 2018
Rubberduck.Core/UI/Command/MenuItems/CommandBars/AppCommandBarBase.cs
Outdated
Show resolved
Hide resolved
…nto CleanComSafeLeakRound2 # Conflicts: # Rubberduck.VBEditor.VBA/SafeComWrappers/Application/FallbackApp.cs # Rubberduck.VBEditor.VBA/SafeComWrappers/VB/VBE.cs # RubberduckTests/CodeExplorer/CodeExplorerTests.cs
Vogel612
reviewed
Nov 6, 2018
| @@ -235,6 +233,9 @@ public void Dispose() | |||
| } | |||
|
|
|||
| _disposed = true; | |||
| _parser?.Dispose(); | |||
| _vbe?.Dispose(); | |||
| _tokenSource.Dispose(); | |||
There was a problem hiding this comment.
why are these after the flicking the _disposed switch? That feels a little wrong
There was a problem hiding this comment.
I thought that was what we were supposed to -- if we throw during the dispose, the pooch is totally screwed anyway? At least subsequent calls would not throw again (but we're still screwed).
| xmlSS.WriteEndElement(); //Close Worksheet | ||
| xmlSS.WriteEndElement(); //Close Workbook | ||
| xmlSS.WriteEndDocument(); | ||
| xmlSS.Close(); |
There was a problem hiding this comment.
While you're touching this, one could try extract these blocks with an explanatory comment into their own methods...
There was a problem hiding this comment.
TBH I question whether we should be even doing that. Don't they provide some kind of API for writing OpenXMLs? Doing this all by hand feels wrong.... I'd rather defer that for another PR.
| _typeInfosWrapped = _typeInfosWrapped ?? new DisposableList<TypeInfoWrapper>(); | ||
| _typeInfosWrapped.Add(outVal); | ||
| _typeInfosWrapped?.Dispose(); | ||
| _typeInfosWrapped = _typeInfosWrapped ?? new DisposableList<TypeInfoWrapper>(); |
…nto CleanComSafeLeakRound2
bclothier
added
PR-Status: Review Requested
…nto CleanComSafeLeakRound2 # Conflicts: # Rubberduck.CodeAnalysis/QuickFixes/IgnoreOnceQuickFix.cs # Rubberduck.Resources/Rubberduck.Resources.csproj
bclothier
removed
the
PR-Status: Conflicting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDisposableAnalyzerswhich helped few legitimate misuse ofIDisposable. However I ended up commenting it out as we have far too many false positive. I left it as comment so once a PR addressing the issue Annotations for cases the analyzer can't figure out. DotNetAnalyzers/IDisposableAnalyzers#126 is merged, we can re-test using it.As noted in the comments for #3645, not all items in the COM safe get disposed due to
RaceOnRCWDisconnecterrors. This is attributed to the fact that there may be other threads running that accesses the SCWs during the shutdown. The PR does not address this as this should be its own PR. One possible fix for that is to implement theVBEEvents.TerminateEventsto put in the necessary kill switch for command buttons and any other objects that needs to query a SCW.