-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diff for compound when transforming actual [onto main] #1440
Fix diff for compound when transforming actual [onto main] #1440
Conversation
There’s something fishy going on with the 1.8.7 build and the implicit expectation detection.
|
.to output(/baz/).to_stdout | ||
.and output(/qux/).to_stderr | ||
} | ||
.to fail_including( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what is breaking the built, it seems antiquated [because it is] but 1.8.7 required:
thing.
to(
over:
thing
.to(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
With this, the 4.0 pr is redundant.
Jon, do you mind merging thus and handling ci for diff-lcs separately?
0c6ae44
to
7e13447
Compare
Previously, we were passing the untransformed actual to the differ. Now, we take it from the matchers. fixes rspec#1317
More 1.8.7 fixes
7e13447
to
9b44765
Compare
Thank you for pushing this to completion, @henrahmagix ! |
Thanks to you and Jon for fixing and finishing it! 🙌 |
…al-diff-on-main Fix diff for compound when transforming actual
fixes #1317
fixes #1406
resolves #1319
I cherry-picked the commits from #1319 onto 3-12-maintenance, they applied without conflicts, then I ran the scripts called in the test CI action and they all passed. I pushed this to 3-12-maintenance...henrahmagix:fix-compound-redefined-actual-diff-on-3-12 just for good measure =)
I did the same on main, bundle installed fine, but I wasn't able to run any of the tests locally because I kept getting the following error:
So I hope the tests pass similarly when run in CI because I can't confirm locally unfortunately☺️