Fix diff for compound when transforming actual #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
commented
Sep 4, 2021
| it 'shows the reassigned value in diff' do | ||
| expected_failure = | ||
| dedent(<<-EOS) | ||
| | expected "hello\\nworld" to eq downcase "bonjour\\nmonde" |
There was a problem hiding this comment.
Reassigning works slightly different from redefining - this line either has the original, or the new actual.
Obviously, this is the reason I didn't DRY up those two examples.
pirj
force-pushed
the
fix-compound-redefined-actual-diff
branch
from
f5c90f1
to
dab40b8
Compare
pirj
force-pushed
the
fix-compound-redefined-actual-diff
branch
from
dab40b8
to
a4d03fa
Compare
pirj
force-pushed
the
fix-compound-redefined-actual-diff
branch
from
a4d03fa
to
8a4960e
Compare
pirj
force-pushed
the
fix-compound-redefined-actual-diff
branch
from
8a4960e
to
0642760
Compare
|
@JonRowe Any objections to merge this? |
Previously, we were passing the untransformed actual to the differ. Now, we take it from the matchers. fixes #1317
pirj
force-pushed
the
fix-compound-redefined-actual-diff
branch
from
0642760
to
56b9b74
Compare
|
I manually applied these changes to my local copy of 3.12.2 and it worked 100%! I would loooooove this to get released on the 3.x.x version pretty please? |
|
Would you send a PR to main? I’ away from my computer, but would happily approve the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were passing the untransformed actual to the differ.
Now, we take it from the matchers.
fixes #1317
fixes #1406