ros-{DISTRO}-rmw-connextdds should be installed. #3505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <[email protected]>
Yadunund
added
the
backport-iron
1 task
|
@clalancette do we backport all here? |
clalancette
reviewed
May 9, 2023
| @@ -43,7 +43,7 @@ You will need to accept a license from RTI. | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| sudo apt update && sudo apt install -q -y rti-connext-dds-6.0.1 | |||
| sudo apt update && sudo apt install -q -y rti-connext-dds-6.0.1 ros-{DISTRO}-rmw-connextdds | |||
There was a problem hiding this comment.
I'm not sure that we should do this here. The text below seems to assume that we will be building the RMW from source, not installing it as a debian package.
I think really that this whole page needs to be revamped, since it is pretty confusing right now. We don't necessarily need to do that in here, but we should probably file a bug about it to follow up with later.
There was a problem hiding this comment.
sounds good to me, will post the issue with description as follow-up.
|
follow-up issue #3573 created, i will go ahead to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of osrf/ros2_test_cases#713