-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add : get clients, servers info #1307
Open
leeminju531
wants to merge
1
commit into
ros2:rolling
Choose a base branch
from
leeminju531:add-clients-servers-info
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2280,6 +2280,66 @@ def get_subscriptions_info_by_topic( | |||||
no_mangle, | ||||||
_rclpy.rclpy_get_subscriptions_info_by_topic) | ||||||
|
||||||
def get_clients_info_by_service( | ||||||
self, | ||||||
service_name: str, | ||||||
no_mangle: bool = False | ||||||
) -> List[TopicEndpointInfo]: | ||||||
""" | ||||||
Return a list of clients on a given service. | ||||||
|
||||||
The returned parameter is a list of TopicEndpointInfo objects, where each will contain | ||||||
the node name, node namespace, service type, service endpoint's GID, and its QoS profile. | ||||||
|
||||||
When the ``no_mangle`` parameter is ``True``, the provided ``service_name`` should be a | ||||||
valid service name for the middleware (useful when combining ROS with native middleware | ||||||
(e.g. DDS) apps). When the ``no_mangle`` parameter is ``False``,the provided | ||||||
``service_name`` should follow ROS service name conventions. | ||||||
|
||||||
``service_name`` may be a relative, private, or fully qualified service name. | ||||||
A relative or private service will be expanded using this node's namespace and name. | ||||||
The queried ``service_name`` is not remapped. | ||||||
|
||||||
:param service_name: The service_name on which to find the clients. | ||||||
:param no_mangle: If ``True``, `service_name` needs to be a valid middleware service | ||||||
name, otherwise it should be a valid ROS service name. Defaults to ``False``. | ||||||
:return: A list of TopicEndpointInfo for all the clients on this service. | ||||||
""" | ||||||
return self._get_info_by_topic( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how about having
Suggested change
|
||||||
service_name, | ||||||
no_mangle, | ||||||
_rclpy.rclpy_get_clients_info_by_service) | ||||||
|
||||||
def get_servers_info_by_service( | ||||||
self, | ||||||
service_name: str, | ||||||
no_mangle: bool = False | ||||||
) -> List[TopicEndpointInfo]: | ||||||
""" | ||||||
Return a list of servers on a given service. | ||||||
|
||||||
The returned parameter is a list of TopicEndpointInfo objects, where each will contain | ||||||
the node name, node namespace, service type, service endpoint's GID, and its QoS profile. | ||||||
|
||||||
When the ``no_mangle`` parameter is ``True``, the provided ``service_name`` should be a | ||||||
valid service name for the middleware (useful when combining ROS with native middleware | ||||||
(e.g. DDS) apps). When the ``no_mangle`` parameter is ``False``,the provided | ||||||
``service_name`` should follow ROS service name conventions. | ||||||
|
||||||
``service_name`` may be a relative, private, or fully qualified service name. | ||||||
A relative or private service will be expanded using this node's namespace and name. | ||||||
The queried ``service_name`` is not remapped. | ||||||
|
||||||
:param service_name: The service_name on which to find the servers. | ||||||
:param no_mangle: If ``True``, `service_name` needs to be a valid middleware service | ||||||
name, otherwise it should be a valid ROS service name. Defaults to ``False``. | ||||||
:return: A list of TopicEndpointInfo for all the servers on this service. | ||||||
""" | ||||||
return self._get_info_by_topic( | ||||||
service_name, | ||||||
no_mangle, | ||||||
_rclpy.rclpy_get_servers_info_by_service) | ||||||
|
||||||
def wait_for_node( | ||||||
self, | ||||||
fully_qualified_node_name: str, | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead we could return
ServiceEndpointInfo
?I think we can introduce
EndpointInfo
base class thenTopicEndpointInfo
andServiceEndpointInfo
can inheritEndpointInfo
base class. this is more appropriate implementation sinceTopicEndpointInfo
for services does not have topic type, topic type hash. this requires the bit of refactoring for classes, but i think that is the right path we can take here.@clalancette @sloretz what do you think?