Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isNan or isValid to Vector and Quaternion #742

Open
kyle-basis opened this issue Dec 5, 2024 · 1 comment
Open

Add isNan or isValid to Vector and Quaternion #742

kyle-basis opened this issue Dec 5, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kyle-basis
Copy link

kyle-basis commented Dec 5, 2024 •
edited
Loading

Feature description

It would be great for validation if Vector and Quaternion had validity checks built in, for NaN (and magnitude on Quaternion). This could would make insertTransformImpl cleaner

See https://github.com/ros2/geometry2/pull/741/files#r1868535923

Implementation considerations

N/A
@kyle-basis kyle-basis mentioned this issue Dec 5, 2024
Open
@kscottz kscottz added the good first issue Good for newcomers label Dec 6, 2024
@sloretz sloretz added the help wanted Extra attention is needed label Dec 20, 2024
@obamwonyi
Copy link

Hi can I work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kscottz @sloretz @obamwonyi @kyle-basis