Update generate_parameter_library dependency in steering_controllers_library (backport #1465) #1468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically the
generate_parameter_library
is a build dependency, but it generate an header and a target that are part of the public interface of the library, and that depend on a series of CMake targets (fmt::fmt
,rsl::rsl
and more, see https://github.com/PickNikRobotics/generate_parameter_library/blob/0346fde52ba515593bd51b96bc520fa872af5b2a/generate_parameter_library/cmake/generate_parameter_library.cmake#L85) that are not listed as dependency of thesteering_controllers_library
package. The easiest solution to ensure that all the transitive dependencies of the code generated bygenerate_parameter_library
are available is to simply addgenerate_parameter_library
as a regular dependency, that is also the solution suggested bygenerate_parameter_library
documentation.Checklist:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)This is an automatic backport of pull request #1465 done by [Mergify](https://mergify.com).