Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_parameter_library dependency in steering_controllers_library (backport #1465) #1468

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 2, 2025

Technically the generate_parameter_library is a build dependency, but it generate an header and a target that are part of the public interface of the library, and that depend on a series of CMake targets (fmt::fmt, rsl::rsl and more, see https://github.com/PickNikRobotics/generate_parameter_library/blob/0346fde52ba515593bd51b96bc520fa872af5b2a/generate_parameter_library/cmake/generate_parameter_library.cmake#L85) that are not listed as dependency of the steering_controllers_library package. The easiest solution to ensure that all the transitive dependencies of the code generated by generate_parameter_library are available is to simply add generate_parameter_library as a regular dependency, that is also the solution suggested by generate_parameter_library documentation.

Checklist:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

This is an automatic backport of pull request #1465 done by [Mergify](https://mergify.com).

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (66337ce) to head (1612a8a).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1468      +/-   ##
==========================================
- Coverage   66.75%   66.72%   -0.03%     
==========================================
  Files         113      113              
  Lines       13337    13337              
  Branches     8245     8244       -1     
==========================================
- Hits         8903     8899       -4     
+ Misses       1442     1436       -6     
- Partials     2992     3002      +10     
Flag Coverage Δ
unittests 66.72% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@christophfroehlich christophfroehlich enabled auto-merge (squash) January 2, 2025 20:22
@christophfroehlich christophfroehlich merged commit 0e79d1e into humble Jan 2, 2025
13 of 14 checks passed
christophfroehlich pushed a commit that referenced this pull request Jan 2, 2025
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1465 branch January 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants