Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Fix the JTC length_error exceptions in the tests (backport #1360) #1362

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

Fix the exception in JTC tests from time to time

     [INFO] [1730930292.973865185] [test_joint_trajectory_controller]: Using 'splines' interpolation method.
    [INFO] [1730930292.974352669] [test_joint_trajectory_controller]: Action status changes will be monitored at 20.00 Hz.
    terminate called after throwing an instance of 'std::length_error'
      what():  basic_string::_M_create

https://github.com/ros-controls/ros2_controllers/actions/runs/11712509515/job/32623343057?pr=1297


This is an automatic backport of pull request #1360 done by Mergify.

Copy link
Contributor Author

mergify bot commented Nov 8, 2024

Cherry-pick of 7ed1a0e has failed:

On branch mergify/bp/iron/pr-1360
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 7ed1a0e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   joint_trajectory_controller/test/test_trajectory_controller_utils.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich
Copy link
Contributor

CI fails because of #1354

@christophfroehlich christophfroehlich marked this pull request as draft November 9, 2024 08:17
saikishor and others added 3 commits November 11, 2024 15:50
(cherry picked from commit 7ed1a0e)

# Conflicts:
#	joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (9b6aa99) to head (c5458ed).
Report is 3 commits behind head on iron.

Files with missing lines Patch % Lines
...ntroller/test/test_trajectory_controller_utils.hpp 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1362      +/-   ##
==========================================
- Coverage   65.09%   65.08%   -0.01%     
==========================================
  Files         107      107              
  Lines       12184    12191       +7     
  Branches     7494     7496       +2     
==========================================
+ Hits         7931     7935       +4     
  Misses       1534     1534              
- Partials     2719     2722       +3     
Flag Coverage Δ
unittests 65.08% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller/test/test_trajectory_controller_utils.hpp 76.92% <71.42%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

@christophfroehlich christophfroehlich merged commit fd8b434 into iron Nov 11, 2024
9 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1360 branch November 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants