Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch and fix API breaking to allow Humble to work with Gazebo Garden #268

Open
wants to merge 1 commit into
base: iron
Choose a base branch
from

Conversation

federicociresola
Copy link

Hi guys,
I created this PR to allow Humble to work with Gazebo Garden.
I started to work with iron branch because it contains the porting from ignition to gazebo API. I discovered that the ros2_control repository has changed the API from Humble to Iron. Therefore, I updated the code with old version of ros2_control's API.

It seems to work without problem with Humble and Garden. My idea is to keep a two different branches, so a person can choose if need to work with Gazebo Garden or Ignition Fortress.

Tell me what do you think about this idea

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you can see there are many files with changes, I can't review this PR. Can you open cleaner PR or edit this PR to contain only the changes that you want to contribute?

@federicociresola federicociresola changed the base branch from humble to iron April 2, 2024 13:25
@federicociresola
Copy link
Author

sorry, I just noticed that I made a mistake on the branch. My idea is not merge this code in the branch iron but keep them in two difference branches. Tell me if it is possible

@destogl
Copy link
Member

destogl commented Apr 9, 2024

@federicociresola as we will not be able to relese this. It doesn't make much sense to merge this as you will anyway need to build everything from source, you can also work from your fork.

@federicociresola
Copy link
Author

@destogl My idea is not merge it on main branch but create a separate branch (I don't know if it is possible because I am quite new in this world to contribute on public repository). I'm asking this because I am updating the code of create3 to work with Humble and Gazebo Garden (the idea is to make a PR for that project when I will finish) and it needs this patch.
Therefore I thought that it was good for the community if they can use it from official repository also if they have to clone the repository and compile it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants