Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sheets in the correct order #196

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Extract sheets in the correct order #196

merged 2 commits into from
Apr 9, 2015

Commits on Apr 8, 2015

  1. Extract sheets in the correct order

    @stevendaniels
    stevendaniels committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    474c40c View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2015

  1. Refactored Roo::Excelx#process_zipfile 

    Extracted another method from process_zipfile. I could do more
refactoring to reduce the line count, but readability might suffer.
e.g.

      when /sharedstrings.xml$/
        ...
      when /styles\.xml$/
        ...

becomes

    when /(sharedstrings|styles)\.xml$/
      "#{tmpdir}/roo_#{Regexp.last_match[1]}.xml"
    @stevendaniels
    stevendaniels committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    4e93b7c View commit details
    Browse the repository at this point in the history