Extract sheets in the correct order #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but I think |
Extracted another method from process_zipfile. I could do more
refactoring to reduce the line count, but readability might suffer.
e.g.
when /sharedstrings.xml$/
...
when /styles\.xml$/
...
becomes
when /(sharedstrings|styles)\.xml$/
"#{tmpdir}/roo_#{Regexp.last_match[1]}.xml"
|
I extracted another method, but I don't see anymore easy refactors. I don't like the Those changes can wait until after the 2.0.0 release (#172). |
simonoff
added a commit
that referenced
this pull request
Apr 9, 2015
Extract sheets in the correct order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166.
Both Numbers 3.1 and Google are capable of creating
xlsxdocuments with sheets that don't fit the normal order. Therefore, these changes are already tested under the Numbers 3.1 export test case.https://github.com/stevendaniels/roo/blob/return-the-correct-sheet/test/test_roo.rb#L1954-L1967