Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto alignment #109

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

auto alignment #109

wants to merge 14 commits into from

Conversation

kirbt
Copy link
Contributor

@kirbt kirbt commented Mar 30, 2024

shuffleboard to guide driveteam in positioning robot

@kirbt kirbt marked this pull request as ready for review March 30, 2024 22:00
Copy link

@bobtseattle bobtseattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking to see if those tolerances fine enough to be useful?

TAKBS2412
TAKBS2412 previously approved these changes Mar 30, 2024
@kirbt kirbt requested a review from TAKBS2412 April 2, 2024 20:49
@kirbt kirbt requested a review from TAKBS2412 April 4, 2024 01:53
Copy link
Contributor

@TAKBS2412 TAKBS2412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's discuss if we should merge this in pre-DCMP or not tomorrow.

if (autoEnabled) {
if (AutoLogic.getSelectedAuto() != null && SubsystemConstants.DRIVEBASE_ENABLED) {
if (autoEnabled && SubsystemConstants.DRIVEBASE_ENABLED) {
if (AutoLogic.getSelectedAuto() != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This can also be combined into the previous if statement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants