Added possibility to change model and link colors in Meshcat visualizer #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
May 17, 2024
|
Any specific comment @GiulioRomualdi ? |
GiulioRomualdi
approved these changes
May 19, 2024
In theory yes. Clearly I might have introduced new bugs, but I tested it also with an ergoCub model and seems to behave as usual. |
|
Thanks! @S-Dafarra do you need a release? |
That would be nice, but not urgent. At the moment it would be a runtime dependency for an application introduced in ami-iit/hippopt#16. So it is not blocking anyhow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.