Request to merge the following minor improvements: #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- openai_api_key was asked in main.py but not passed along when needed. The user had to both pass it in the code and UI. Now the user can pass it only in the UI. - To allow the user to only pass their openai_api_key in the UI and even beeing able to run the UI, the embeddings had to go inside the create_db_from_youtube_video_url function. With this change the user is now able to only interact with the UI and not get any wired errors. - Lastly I increase the number of char allowed for the openai_api_key and the yt url, since the openai_api_key is longer than 50 chars and so are some yt_urls. In those cases when the user try to paste their string, is not allowed. I increase the limits to 150 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openai_api_key was asked in main.py but not passed along when needed. The user had to both pass it in the code and UI. Now the user can pass it only in the UI.
To allow the user to only pass their openai_api_key in the UI and even be able to run the UI, the embeddings had to go inside the create_db_from_youtube_video_url function. With this change, the user is now able to only interact with the UI and not get any wired errors.
Lastly, I increased the number of char allowed for the openai_api_key and the yt url, since the openai_api_key is longer than 50 chars and so are some yt_urls. In those cases when the user tries to paste their string, is not allowed. I increased the limit to 150 chars.