Prerender resources pages #7
Conversation
| let resources = await getAllResources({ octokit }); | ||
| return { | ||
| resources, | ||
| featuredResource: null, | ||
| }; |
There was a problem hiding this comment.
This used to have all the selectedCategory/selectedTags stuff - moved to a clientLoader because SSG won't have query params
There was a problem hiding this comment.
Haha yeah, going back to the server for this doesn't even super make sense, since we have to send down all the data anyway and it's not changing in between deploys
Cool that await serverLoader(); just grabs whatever the prerender phase created. Never really thought about it but makes total sense
| return { ...resource, siteUrl }; | ||
| }; | ||
|
|
||
| export async function clientLoader({ |
There was a problem hiding this comment.
Pretty much everything in here is just copied from what we used to do on the server
| <main> | ||
| {show ? ( | ||
| <div className="container flex flex-1 flex-col items-center md:mt-8"> | ||
| <p>Loading resources....</p> |
There was a problem hiding this comment.
Flash in a loading message if they stare at a blank screen for >2 seconds which should really never happen
| // Force this layout HydrateFallback to render on initial load so we can | ||
| // eliminate the footer and avoid needing to fill height with a skeleton | ||
| export function clientLoader() { | ||
| return null; | ||
| } | ||
| clientLoader.hydrate = true; |
There was a problem hiding this comment.
This might be a bug or a gap in RR - I thought we bubbled to the nearest HydrateFallback but it looks like it's 1:1 so just having the clientLoader.hydrate on the child route is not enough to get this route HydrateFallback to show. I wanted to do it at this level so we didn't have the footer collapse up on us when there was no content and cause a flicker. By doing it here I can just hide the footer until the content is ready.
There was a problem hiding this comment.
hmmm yeah, feels like it should work the way you expected. Either way, this approach makes sense
| @@ -0,0 +1,2 @@ | |||
| # A token to increase the rate limiting from 60/hr to 1000/hr | |||
| GITHUB_TOKEN="" | |||
There was a problem hiding this comment.
Am I missing something? I added this to my .env file but build fails
There was a problem hiding this comment.
huh - yeah I must have exported it locally in the shell during my testing - added dotenv 👍
|
Went ahead and fixed some type errors btw @brophdawg11 |
brophdawg11
force-pushed
the
brophdawg11/resources
branch
from
2757dea to
3fcccbe
Compare
|
@brophdawg11 thanks for fixing that up and adding the nav. I'm good to merge this whenever you are! Also happy to cleanup the |
|
I'll take a stab at it - it's a nice easy/defined piece of work I can do before vacation :) |
Mostly copied stuff straight over - just had to move the filtering to a
clientLoader