Skip to content

Commit 3fcccbe

Browse files
committed
Add dotenv, fix lint issues, add header link
1 parent 3662b18 commit 3fcccbe

File tree

6 files changed

+26
-9
lines changed

6 files changed

+26
-9
lines changed

.github/workflows/pages.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ jobs:
1818
if: github.repository == 'remix-run/remix-v2-website'
1919
name: 🏗 Build
2020
runs-on: ubuntu-latest
21+
env:
22+
GH_TOKEN: ${{ github.token }}
2123
steps:
2224
- name: ⬇️ Checkout repo
2325
uses: actions/checkout@v4
@@ -31,7 +33,7 @@ jobs:
3133
run: npm ci
3234

3335
- name: 🏗 Build
34-
run: npm run build
36+
run: npm run build:ci
3537

3638
- name: ⬆️ Upload static files as artifact
3739
uses: actions/upload-pages-artifact@v3

app/routes/_extras.resources._index/data.server.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
import {
2-
getAllResources,
3-
type Category,
4-
type Resource,
5-
} from "~/lib/resources.server";
6-
import { categories } from "./ui";
1+
import { getAllResources } from "~/lib/resources.server";
72
import { octokit } from "~/lib/github.server";
83

9-
export async function getResourcesForRequest(request: Request) {
4+
export async function getResourcesForRequest() {
105
let resources = await getAllResources({ octokit });
116
return {
127
resources,

app/routes/docs.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ function Header() {
150150
<div className="hidden items-center md:flex">
151151
<HeaderMenuLink to={href("/docs")}>Docs</HeaderMenuLink>
152152
<HeaderMenuLink to="https://remix.run/blog">Blog</HeaderMenuLink>
153+
<HeaderMenuLink to="/resources">Resources</HeaderMenuLink>
153154
</div>
154155
<div className="flex items-center gap-2">
155156
<HeaderLink
@@ -375,6 +376,7 @@ function HeaderMenuMobile({ className = "" }: { className: string }) {
375376
<div className="flex flex-col">
376377
<HeaderMenuLink to={href("/docs")}>Docs</HeaderMenuLink>
377378
<HeaderMenuLink to="https://remix.run/blog">Blog</HeaderMenuLink>
379+
<HeaderMenuLink to={href("/resources")}>Resources</HeaderMenuLink>
378380
</div>
379381
</DetailsPopup>
380382
</DetailsMenu>

app/ui/header.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export function Header({
3838
<nav className="hidden gap-8 md:flex" aria-label="Main">
3939
<HeaderLink to={href("/docs")}>Docs</HeaderLink>
4040
<HeaderLink to="https://remix.run/blog">Blog</HeaderLink>
41+
<HeaderLink to={href("/resources")}>Resources</HeaderLink>
4142
</nav>
4243

4344
<HeaderMenuMobile className="md:hidden" />
@@ -65,6 +66,7 @@ function HeaderMenuMobile({ className = "" }: { className: string }) {
6566
<nav className="flex flex-col gap-2 px-2 py-2.5">
6667
<HeaderLink to={href("/docs")}>Docs</HeaderLink>
6768
<HeaderLink to="https://remix.run/blog">Blog</HeaderLink>
69+
<HeaderLink to={href("/resources")}>Resources</HeaderLink>
6870
</nav>
6971
</DetailsPopup>
7072
</DetailsMenu>

package-lock.json

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
"sideEffects": false,
88
"type": "module",
99
"scripts": {
10-
"build": "react-router build",
10+
"build": "NODE_OPTIONS=\"-r dotenv/config\" npx react-router build",
11+
"build:ci": "react-router build",
1112
"dev": "react-router dev",
1213
"format": "prettier --write ./",
1314
"start": "sirv -p 5173 build/client",
@@ -63,6 +64,7 @@
6364
"@vitejs/plugin-react": "^4.4.1",
6465
"@vitest/coverage-v8": "^3.2.4",
6566
"autoprefixer": "^10.4.21",
67+
"dotenv": "^17.2.1",
6668
"happy-dom": "^17.4.4",
6769
"oxlint": "^1.12.0",
6870
"postcss": "^8.4.33",

0 commit comments

Comments
 (0)