Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install virtualenv as user. #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions infrared/common/roles/shade/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
name: pip

- name: install virtualenv pip module
become: yes
pip:
name: virtualenv
state: forcereinstall
extra_args: --user

# required to avoid any conflicts in venv with
# different packages versions (especially shade)
Expand All @@ -31,12 +31,10 @@
# do not use shimming for these two special packages
- name: shade virtualenv core deps
pip:
name: "{{ item }}"
name:
- setuptools>=39.0.0
- pip>=10.0.1
virtualenv: "{{ shade_path_venv }}"
virtualenv_command: "{{ ansible_env.HOME }}/.local/bin/virtualenv"
with_items:
- setuptools>=39.0.0
- pip>=10.0.1

- name: shade virtualenv deps
pip:
Expand All @@ -48,4 +46,3 @@
# see https://projects.engineering.redhat.com/browse/RHOSINFRA-1562
# TODO: unpin shade to avoid other conflicts
virtualenv: "{{ shade_path_venv }}"
virtualenv_command: "{{ ansible_env.HOME }}/.local/bin/virtualenv"