Don't install virtualenv as user. #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoRessi
force-pushed
the
fix-shade-virtualenv
branch
from
77f914b to
5893944
Compare
FedericoRessi
force-pushed
the
fix-shade-virtualenv
branch
from
5893944 to
874440d
Compare
|
@FedericoRessi, Can you please provide more info why you you need that change, cause we recently switched to the --user mode installation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package installation as user would fail in the case python is running inside an user virtualenv. I personally think this playbook should limit to check virtualenv is installed more than actually installing it because it is out of its scope. Most of the time virtualenv is already installed in a machine where python is installed. Some time it is not and for such few cases a regular "pip install virtualenv" should be enough. Once virtualenv is installed, I think we should install packages inside virtualenvs specific for tools to be installed instead of using --user. The reason is installing tools as root or as user has the same problem of not taking in account two or more tools could have non compatible requirements and for such cases, virtualenv is the right solution.