Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add support for host task #344

Closed
wants to merge 1 commit into from
Closed

[SYCL][Graph] Add support for host task #344

wants to merge 1 commit into from

Conversation

mfrancepillois
Copy link
Collaborator

Adds graph partitioning process to handle host task dependencies.
Adds e2e tests.
Updates design doc.

@mfrancepillois mfrancepillois added the Graph Implementation Related to DPC++ implementation and testing label Nov 24, 2023
EwanC
EwanC reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I need to take another look at makePartitions() to get my head around it. Here's my comments so far on mostly superficial points.

sycl/test-e2e/Graph/RecordReplay/host_task_successive.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/Graph/RecordReplay/host_task_successive.cpp Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/Graph/Inputs/interop-level-zero-get-native-mem.cpp Show resolved Hide resolved
sycl/test-e2e/Graph/Inputs/host_task_single.cpp Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Show resolved Hide resolved
EwanC
EwanC approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some more minor comments, this is a nice feature addition.

The longer form descriptive comments are very helpful too.

sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc Outdated Show resolved Hide resolved
sycl/test-e2e/Graph/RecordReplay/host_task_in_order.cpp Show resolved Hide resolved
sycl/test-e2e/Graph/Inputs/interop-level-zero-get-native-mem.cpp Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
EwanC
EwanC reviewed Nov 30, 2023
View reviewed changes
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Show resolved Hide resolved
EwanC
EwanC approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New diagrams are great, thanks ⭐

sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
julianmi
julianmi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@julianmi julianmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/unittests/Extensions/CommandGraph.cpp Outdated Show resolved Hide resolved
sycl/unittests/Extensions/CommandGraph.cpp Show resolved Hide resolved
@mfrancepillois
[SYCL][Graph] Add support for host task
dc5a2b8 
Adds graph partitioning process to handle host task dependencies.
Adds e2e tests.
Updates design doc.
@mfrancepillois
Copy link
Collaborator Author

Upstream PR : intel#12064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reble reble reble left review comments

@EwanC EwanC EwanC approved these changes

@julianmi julianmi julianmi approved these changes

@Bensuo Bensuo Awaiting requested review from Bensuo

Assignees
No one assigned
Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrancepillois @EwanC @reble @julianmi