Pass a device to graph constructor #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reble
approved these changes
Mar 29, 2023
Based on feedback from the Working Group it is clearer to represent the current single device characteristic of a graph by passing a device to the graph constructor that all nodes will target. Then remove the `device` parameter from the explicit API, as it can be added as an overload in a future revision due to experimental nature of the extension A diff of these changes against the commit prior to when the [original multi-device PR](#83) went in can be seen [here](28acfa8...reble:llvm:ewan/single_device)
EwanC
force-pushed
the
ewan/single_device
branch
from
62e89b2 to
ad5df75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from the Working Group it is clearer to represent the current single device characteristic of a graph by passing a device to the graph constructor that all nodes will target. Then remove the
syclDeviceparameter from the explicit API, as due to experimental nature of the extension it can be added in a future revision if needed.A diff of these changes against the commit prior to when the original multi-device PR went in can be seen here