Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update implementation to reflect device specific graph changes #110

Closed
EwanC opened this issue Mar 24, 2023 · 1 comment · Fixed by #140
Closed

Update implementation to reflect device specific graph changes #110

EwanC opened this issue Mar 24, 2023 · 1 comment · Fixed by #140
Assignees
@Bensuo
Labels
Graph Implementation Related to DPC++ implementation and testing

Comments

@EwanC
Copy link
Collaborator

EwanC commented Mar 24, 2023

Our implementation needs to be updated to match the changes introduced in spec PR #83
Most importantly, the API change to add a device to the graph.add() entry-point, but the error checks also need implemented.
@EwanC EwanC added the Graph Implementation Related to DPC++ implementation and testing label Mar 24, 2023
@EwanC
Copy link
Collaborator Author

EwanC commented Mar 28, 2023

This issue is still valid in that the implementation still needs updated, however the revision of the spec to updated too should now reflect the outcome of PR #113

This was referenced Apr 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bensuo Bensuo

Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL] Update graph constructor/finalize to current spec reble/llvm
2 participants
@EwanC @Bensuo