Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waiting on events returned from executable graph submission does not work #139

Closed
Bensuo opened this issue Apr 13, 2023 · 0 comments
Closed

Waiting on events returned from executable graph submission does not work #139

Bensuo opened this issue Apr 13, 2023 · 0 comments
Assignees
@EwanC
Labels
bug Something isn't working Graph Implementation Related to DPC++ implementation and testing

Comments

@Bensuo
Copy link
Collaborator

Bensuo commented Apr 13, 2023 •
edited
Loading

Currently a wait is called on the queue inside the graph immediately after enqueue. Examples which attempt to wait on the event returned from the graph submission will fail without this wait occuring. This should be investigated so that we can remove the queue wait from graph submission.
@Bensuo Bensuo added bug Something isn't working Graph Implementation Related to DPC++ implementation and testing labels Apr 13, 2023
@Bensuo Bensuo self-assigned this Apr 13, 2023
@Bensuo Bensuo changed the title Waiting on events returned from graph submission does not work Waiting on events returned from executable graph submission does not work Apr 13, 2023
@Bensuo Bensuo mentioned this issue Apr 13, 2023
Merged
@EwanC EwanC assigned EwanC and unassigned Bensuo May 26, 2023
@EwanC EwanC mentioned this issue May 26, 2023
Merged
EwanC added a commit that referenced this issue May 29, 2023
@EwanC
[SYCL][Graphs] Remove blocking wait from graph enqueue.
452e7ae 
The current approach uses the same LO PI event for all submissions
of the same graph, and also doesn't use the wait events to
enforce dependencies on the command-list submission. By doing these
in the L0 adapter, we can remove the blocking queue wait from
our graphs submission code in the runtime.

Closes issue #139
EwanC added a commit that referenced this issue May 31, 2023
@EwanC
[SYCL][Graphs] Remove blocking wait from graph enqueue. (#190)
cfbb3a0 
The current approach uses the same LO PI event for all submissions
of the same graph, and also doesn't use the wait events to
enforce dependencies on the command-list submission. By doing these
in the L0 adapter, we can remove the blocking queue wait from
our graphs submission code in the runtime.

Closes issue #139
@EwanC EwanC closed this as completed May 31, 2023
reble pushed a commit that referenced this issue Jun 6, 2023
@EwanC @reble
[SYCL][Graphs] Remove blocking wait from graph enqueue.
441449b 
The current approach uses the same LO PI event for all submissions
of the same graph, and also doesn't use the wait events to
enforce dependencies on the command-list submission. By doing these
in the L0 adapter, we can remove the blocking queue wait from
our graphs submission code in the runtime.

Closes issue #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EwanC EwanC

Labels
bug Something isn't working Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EwanC @Bensuo