Skip to content

Improved BuckleScript method call syntax#941

Open
SanderSpies wants to merge 3 commits intoreasonml:masterfrom
SanderSpies:bucklescript_method
Open

Improved BuckleScript method call syntax#941
SanderSpies wants to merge 3 commits intoreasonml:masterfrom
SanderSpies:bucklescript_method

Conversation

@SanderSpies
Copy link
Contributor

@SanderSpies SanderSpies commented Jan 8, 2017

#849

Changes Foo##bar into Foo."bar"

Note that ## still needs to used for scenario's like: Foo##(something."else").

Also #= has gotten an extra post space during printing as it otherwise will fail to be idempotent.

@chenglou
Copy link
Member

chenglou commented Jan 8, 2017

Context: we're sticking with #= for the moment.

cc spam @bsansouci @Schmavery @jordwalke @yunxing, adding a space after #= ok? I recall some precedence problems around it?

Note that ## still needs to used for scenario's like: Foo##(something."else").

I don't think @bobzhang made such thing work. This compiles to something weird: https://bloomberg.github.io/bucklescript/js-demo/?gist=0d4169c80f571302b5a163ee01556a7e

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 8, 2017

@jordwalke mentioned a better form: Foo["bar"]["more"]. I'll update this PR unless there are objections.

@chenglou
Copy link
Member

chenglou commented Jan 8, 2017

That'd be a bit more tedious than ## and might mislead people into doing foo[stringRef] (though we can warn against that)

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 8, 2017

It requires also some more work, so let's keep it as is.

@bobzhang
Copy link
Contributor

bobzhang commented Jan 8, 2017

@chenglou your example probably is a bug on BuckleScript, it should fail with a nice error msg

@bobzhang
Copy link
Contributor

bobzhang commented Jan 8, 2017

How about using '.=' instead of '#='

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 8, 2017

@bobzhang could easily be added (did a quick experiment).

@bobzhang bobzhang mentioned this pull request Jan 8, 2017
Closed
SanderSpies
SanderSpies commented Jan 8, 2017
View reviewed changes
formatTest/unit_tests/expected_output/bucklescript.re Outdated
preview##style##border#=(
Js.string "1px black dashed"
);
preview."style"."border"#= (
Copy link
Contributor Author

@SanderSpies SanderSpies Jan 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something goes wrong here.

Copy link
Member

@chenglou chenglou Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsansouci

Copy link
Member

@chenglou chenglou Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsansouci @jordwalke

Copy link
Contributor

@bsansouci bsansouci Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong exactly?

Copy link
Contributor Author

@SanderSpies SanderSpies Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I was looking wrong.

@Schmavery
Copy link
Contributor

Schmavery commented Jan 11, 2017

Adding a space (before and) after #= shouldn't result in any parsing issues. In fact, it should fix #856

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 12, 2017

Added support for .=.

@chenglou
Copy link
Member

chenglou commented Jan 12, 2017

Is this ready?

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 12, 2017

Yes, ready for review

@chenglou chenglou mentioned this pull request Jan 15, 2017
Merged
@chenglou
Copy link
Member

chenglou commented Jan 21, 2017

Fack. cc @yunxing is this good to go? If it is, @bobzhang everything's ready on BS' side right?

@bobzhang
Copy link
Contributor

bobzhang commented Jan 21, 2017

this is good, would you do a sanity check on your side that no # character in method name

@SanderSpies SanderSpies mentioned this pull request Jan 24, 2017
Closed
@SanderSpies
Copy link
Contributor Author

SanderSpies commented Jan 27, 2017

Updated with extra check for hash within method name.

@yunxing
Copy link
Contributor

yunxing commented Jan 30, 2017

The parser && printer part looks good to me.

@chenglou Feel free to merge this if the syntax also looks good to you.

@chenglou
Copy link
Member

chenglou commented Feb 1, 2017

This PR works but completely wrecks editor highlighting.

screenshot 2017-02-01 01 01 20

screenshot 2017-02-01 01 02 00

I can fix this for atom (and I guess vscode by extension), @jordwalke what about vim? cc @yunxing for emacs

@chenglou
Copy link
Member

chenglou commented Feb 1, 2017

Will work on making the highlighting work then merge this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chenglou chenglou chenglou left review comments

@bsansouci bsansouci bsansouci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed GH Review: review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SanderSpies @chenglou @bobzhang @Schmavery @yunxing @bsansouci @facebook-github-bot