Merged
Conversation
This is a pretty simple fix. I use the existent parameter `withStringKeys` to when to format the key as an ident, or as a simple string.
Member
|
cc @yunxing |
Member
|
every weird string key should be supported though; Is that hard? I believe the same will apply for #941 |
Contributor
Author
|
@chenglou I think |
Contributor
|
Accidentally lost track on this, looking into it now. |
Contributor
|
Very sorry for the delay. Diff looks good. Let's merge this! |
sansthesis
pushed a commit
to sansthesis/reason
that referenced
this pull request
Apr 19, 2017
This is a pretty simple fix. I use the existent parameter `withStringKeys` to when to format the key as an ident, or as a simple string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty simple fix.
I use the existent parameter
withStringKeysto when to format the keyas an ident, or as a simple string.
For now we don't support
LdotandLapplyin the string keys. I'm not sure what the behavior should be in this case.cc @chenglou