Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria labels to table filters and Import YAML code editor #13293

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Feb 5, 2025

Summary

This adds aria labels to the table filter input and the Import YAML code editor.

Fixes #12818

Occurred changes and/or fixed issues

  • add aria label to the table filter input
  • add aria label the Import YAML code editor

Technical notes summary

🗒️ NOTE: The code mirror component requires a special option, screenReaderLabel, to assign the aria-label to the correct element.

Areas or cases that should be tested

  • Basic table filters should now have an aria label associated with them
  • Import YAML code editor should have an aria label associated with it

Areas which could experience regressions

  • NA

Screenshot/Video

  • NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.11.0 milestone Feb 5, 2025
@rak-phillip rak-phillip requested a review from aalves08 February 5, 2025 18:04
@rak-phillip rak-phillip self-assigned this Feb 5, 2025
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simple change. I think I'll incorporate the screenReaderLabel to my header PR since I think I've reached a viable solution to the keyboard nav problem. 🙏

@rak-phillip rak-phillip merged commit 8f2edd7 into rancher:master Feb 5, 2025
47 of 49 checks passed
@rak-phillip rak-phillip deleted the task/12818-input-labels branch February 5, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix missing label attribute issue with form input control
2 participants