Skip to content

Commit

Permalink
Merge pull request #13293 from rak-phillip/task/12818-input-labels
Browse files Browse the repository at this point in the history
Add aria labels to table filters and Import YAML code editor
  • Loading branch information
rak-phillip authored Feb 5, 2025
2 parents 8355788 + 1129931 commit 8f2edd7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions shell/assets/translations/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2744,6 +2744,8 @@ hpa:

import:
title: Import YAML
editor:
label: YAML Editor
defaultNamespace:
label: Default Namespace
success: |-
Expand Down Expand Up @@ -5375,6 +5377,7 @@ sortableTable:
=1 {{count} {count, plural, =1 {{singularLabel}} other {{pluralLabel}}}}
other {{from} - {to} of {count} {pluralLabel}}}
search: Filter
searchLabel: Filter table results
in: in
addFilter: Add Filter
filterFor: Filter for...
Expand Down
1 change: 1 addition & 0 deletions shell/components/SortableTable/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,7 @@ export default {
v-model="eventualSearchQuery"
type="search"
class="input-sm search-box"
:aria-label="t('sortableTable.searchLabel')"
:placeholder="t('sortableTable.search')"
>
<slot name="header-button" />
Expand Down
1 change: 1 addition & 0 deletions shell/components/YamlEditor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export default {
cm.indentSelection('subtract');
}
},
screenReaderLabel: this.t('import.editor.label'),
// @TODO find a better way to display the outline
// foldOptions: {
// widget: (from, to) => {
Expand Down

0 comments on commit 8f2edd7

Please sign in to comment.