Fleet Resource Handling - Replace warning banners with tooltips #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
cnotv
requested changes
Jan 13, 2025
|
|
||
| it('should have keep-resources checkbox and tooltip', () => { | ||
| const correctDriftCheckbox = wrapper.find('[data-testid="GitRepo-keepResources-checkbox"]'); | ||
| const tooltip = wrapper.findAll('[data-testid="GitRepo-keepResources-checkbox"] .v-popper--has-tooltip'); |
There was a problem hiding this comment.
it should not use classes as an identifier.
You could set the data-testid on the span directly or pass it as prop to achieve this. Otherwise use HTML tags, but CSS classes are a cause of issues.
There was a problem hiding this comment.
Do you mean to to avoid using the .v-popper--has-tooltip class ?
Do we an example in our unit tests ?
There was a problem hiding this comment.
What do you mean by example? All our unit tests have data over classes.
Given the existing markup, you could use data-checkbox-ctrl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11300
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Fleet -> GitRepo -> create or edit
Areas which could experience regressions
Screenshot/Video
Checklist