Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fleet git repo wizard #10843

Open
richard-cox opened this issue Apr 19, 2024 · 5 comments
Open

Improve fleet git repo wizard #10843

richard-cox opened this issue Apr 19, 2024 · 5 comments
Assignees
Labels
area/fleet kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Apr 19, 2024

Is your feature request related to a problem? Please describe.

  • Wizard uses three info notification banners
    • these are all rather disruptive instead of informative
  • Wizard uses one secondary banner
    • This should probably just be text
  • Grammar in Always Keep Resources banner could be improved
    • When enabled above, resources will be kept when deleting a GitRepo or Bundle - only Helm release secrets will be deleted.

Describe the solution you'd like

  • Investigate what could replace banner for Enter a valid HTTPS or SSH URL to a git repository.
  • Update checkbox (if not already able to) to have description text near to the checkbox label and use for Enable Self-Healing and Always Keep Resources
  • When enabled above --> When enabled
  • Just use text for the Paths text

Additional context

  • added to 2.9.next1 as these are visual bugs, but could all wait for 2.10.0
@richard-cox richard-cox added this to the v2.9.next1 milestone Apr 19, 2024
@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 19, 2024
@gaktive gaktive modified the milestones: v2.9.next1, v2.10.0 Jul 2, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

/backport v2.10.1

@torchiaf
Copy link
Member

@torchiaf torchiaf self-assigned this Jan 20, 2025
@torchiaf
Copy link
Member

@richard-cox what do you mean with Just use text for the Paths text ?

@richard-cox
Copy link
Member Author

@torchiaf Good question, it relates to the text The root of the repo is used by default. To use one or more different directories, add them here. that's currently in a secondary banner. Just needs moving out of that banner and added straight tothe page

@torchiaf
Copy link
Member

@richard-cox Ok, I removed the banner from Paths ArrayList and now using a tooltip. Hope this work, please take a look #13162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Projects
None yet
Development

No branches or pull requests

4 participants