[Draft PR] Bugfix improve the logic for inserting copy nodes after the last use of tensor in buffer pass. #13857
Conversation
RihaanBH-1810
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13857
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6e2817f with merge base 176800e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @RihaanBH-1810! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This PR needs a
|
| if mutated_node_name is None: | ||
| user_output_nodes.append(return_node) | ||
| user_returns.append(return_node) | ||
| continue | ||
|
|
||
| # Mutable buffer grab the node |
There was a problem hiding this comment.
This is a bit of a stupid question since I think I wrote this code, but looking back on it. Are mutated node and return node not the exact same node?
| for node in gm.graph.nodes: | ||
| if node.op == "output": | ||
| output_node = node | ||
| break |
There was a problem hiding this comment.
nit: go back to gm.graph.output_node()
This is a draft PR to fix issue #7345