This repository has been archived by the owner on Aug 1, 2020. It is now read-only.
Add support for Django 3.0 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django-crispy-forms 1.9 only supports Django 2.2 and higher so as a consequence this package had to drop support for versions below 2.2.
MarkKoz
added
type: feature
lemonsaurus
approved these changes
Mar 22, 2020
|
I just tried to use the module with Django 3.0 and I noticed that the email input is not working as expected. It gets rendered to
Though on the bulma webpage the CSS-class is solely "input". Could someone please check this? Besides, django-crispy-bulma 0.3 seems not to be on pipy is the intentionally? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-crispy-forms has to be at least version 1.8 for Django 3.0 support, but I pinned it to 1.9 because it seems there were some import issues and deprecation warnings fixed in 1.9.
I haven't extensively tested this and don't really know how, so this has to wait for #31.