Skip to content
This repository has been archived by the owner on Aug 1, 2020. It is now read-only.

Check compatibility with Django 3.0 #31

Open
lemonsaurus opened this issue Mar 21, 2020 · 3 comments
Open

Check compatibility with Django 3.0 #31

lemonsaurus opened this issue Mar 21, 2020 · 3 comments
Labels
area: dependencies Related to package dependencies and management priority: 2 - normal type: feature New feature or request

Comments

@lemonsaurus
Copy link
Member

Probably easiest to just test it with Django 3 and see what happens. I imagine it will probably more or less work.

@MarkKoz MarkKoz added area: dependencies Related to package dependencies and management priority: 2 - normal type: feature New feature or request labels Mar 21, 2020
@MarkKoz
Copy link
Member

MarkKoz commented Apr 23, 2020

Copying #32 (comment) to this issue

I just tried to use the module with Django 3.0 and I noticed that the email input is not working as expected. It gets rendered to

<input type="email" name="email" maxlength="254" class="emailinput" id="id_email">

Though on the bulma webpage the CSS-class is solely "input". Could someone please check this?

@keans
Copy link

keans commented Apr 25, 2020

Another problem is that the ManyToManyField does not seem to be rendered correctly. In the default rendering the layout breaks with following fields. Adding the is-multiple seems to fix the issue:

<div class="select"><div class="select is-multiple">

It gets even worse when enforcing a CheckboxSelectMultiple:

admins = forms.ModelMultipleChoiceField(
        queryset=User.objects.all(),
        widget=forms.CheckboxSelectMultiple(),
)

In this case nothing is shown at all.

@keans
Copy link

keans commented Apr 30, 2020

Another problem for BooleanFields: the input field for the checkbox seems to be rendered twice. For example:

<div id="div_id_is_active" class="field"> 
    <input type="checkbox" name="is_active" class="checkboxinput" id="id_is_active" checked="">
    <label for="" class="label">Is active</label>
    <p class="control">
        <input type="checkbox" name="is_active" class="checkboxinput" id="id_is_active" checked="">
    </p>
    <p id="hint_id_is_active" class="help">Only activated items are shown to the user.</p> </div>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: dependencies Related to package dependencies and management priority: 2 - normal type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants