Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook-aumbry.py #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add hook-aumbry.py #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc4e65
Add hook-aumbry.py
RDCH106 Mar 8, 2021
1fd63d2
Add hook for aumbry (#96)
RDCH106 Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-aumbry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# ------------------------------------------------------------------
# Copyright (c) 2020 PyInstaller Development Team.
#
# This file is distributed under the terms of the GNU General Public
# License (version 2.0 or later).
#
# The full license is available in LICENSE.GPL.txt, distributed with
# this software.
#
# SPDX-License-Identifier: GPL-2.0-or-later
# ------------------------------------------------------------------

# Tested with Aumbry 0.10.0

from PyInstaller.utils.hooks import collect_all

datas, binaries, hiddenimports = collect_all('aumbry')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collect_all() is incredibly inefficient. Does it really need all of data files, binaries, hidden imports, metadata and dependencies? I see no data files or binaries in the aumbry package. The only thing I see in there is use of importlib which will require collect_submodules('aumbry').

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

I am not sure right now, I will check it again!
Thank you for your advice.