Add hook-aumbry.py #96
Conversation
RDCH106
commented
Mar 8, 2021
RDCH106
commented
- Add aumbry suppport:
- https://aumbry.readthedocs.io/en/latest/
|
The thrown error by Travis CI in Python 3.9 configuration probably is not related to the PR: https://travis-ci.org/github/pyinstaller/pyinstaller-hooks-contrib/builds/761933083 Same problem in GitHub Actions: https://github.com/pyinstaller/pyinstaller-hooks-contrib/actions/runs/632186914 |
|
And yes, ignore CI. It's not testing your code. |
Legorooj
force-pushed
the
master
branch
10 times, most recently
from
8003b05 to
df3371d
Compare
✅ Done! |
RDCH106
requested review from
a team and
bwoodsend
and removed request for
a team
|
|
||
| from PyInstaller.utils.hooks import collect_all | ||
|
|
||
| datas, binaries, hiddenimports = collect_all('aumbry') |
There was a problem hiding this comment.
collect_all() is incredibly inefficient. Does it really need all of data files, binaries, hidden imports, metadata and dependencies? I see no data files or binaries in the aumbry package. The only thing I see in there is use of importlib which will require collect_submodules('aumbry').
There was a problem hiding this comment.
Ok
I am not sure right now, I will check it again!
Thank you for your advice.
