Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly check for DataElement before reference value #258

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

wetzelj
Copy link
Contributor

@wetzelj wetzelj commented Sep 11, 2023

Description

Related issues: #256

Updated filter.py empty() function to explicitly check for the tag content being an instance of a DataElement instead of assuming it's a DataElement if it isn't a string.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code follows the style guidelines of this project

Open questions

None

@wetzelj wetzelj mentioned this pull request Sep 11, 2023
3 tasks
@vsoch vsoch merged commit 467b8bd into pydicom:master Sep 11, 2023
@wetzelj
Copy link
Contributor Author

wetzelj commented Sep 12, 2023

Thanks @vsoch!

@vsoch
Copy link
Member

vsoch commented Sep 12, 2023

Thank you @wetzelj !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants