Fix/filter exception #257
Closed
Fix/filter exception #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and values from specified tags.
… and values from specified tags. Changes inspired by modifications within howardpchen's fork of pydicom/deid.
Added sections describing the usage of the new private tag screening functionality which was added to the replace_identifiers method.
Changed default on screen_values from [] to None.
This reverts commit 54c636b.
This reverts commit 7c7a600.
…patterns and values from specified tags. Changes inspired by modifications within howardpchen's fork of pydicom/deid." This reverts commit f839e2f.
|
hey @wetzelj long time no see! I can definitely squash and merge - but is it maybe the case your master branch isn't in sync with upstream? The commit history is... intense! |
|
It is.... but let me redo it and clean it up. I noticed that was... gross. :) Hope you're doing well @vsoch! :) |
|
Replacing with a new PR with a clean commit history |
|
Replaced by #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #256
Updated filter.py empty() function to explicitly check for the tag content being an instance of a DataElement instead of assuming it's a DataElement if it isn't a string.
Hi @vsoch!
Checklist
Open questions
None