Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactoring hash logic to fix possible issue with query param on host route (i.e. timemachine override) #271

Merged
merged 16 commits into from
Feb 27, 2025
Merged

fix: refactoring hash logic to fix possible issue with query param on host route (i.e. timemachine override) #271

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4a38968
fix: removing slash to fix possible issue with query param on host ro…
jordanstith15 Jul 9, 2024
8edc7aa
Merge branch 'main' into feature/COMUI-1386
jordanstith15 Nov 4, 2024
fe81aef
chore: updating lockfile after syncing with main
jordanstith15 Nov 4, 2024
1057281
chore: refactoring processHostUrl function to just use a URL object
jordanstith15 Nov 6, 2024
13c6080
feat(ifc-cli): add support for proxy configuration via a json file
MattCheely Nov 7, 2024
cd15328
chore(release): 6.1.0
Dec 2, 2024
cf36ab1
chore: updating package-lock after syncing with main
jordanstith15 Dec 9, 2024
fe2b77e
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
jordanstith15 Dec 19, 2024
8945ffd
chore(frame-router): simplifying if clause in processHostUrl
jordanstith15 Jan 7, 2025
cf19d6b
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
jordanstith15 Jan 7, 2025
32b707f
chore(ifc-example): changing the hostRootUrl for the example ifc conf…
jordanstith15 Jan 9, 2025
3c39a0e
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
jordanstith15 Jan 14, 2025
a250811
chore(ifc-example): updating lockfile after syncing with main
jordanstith15 Jan 14, 2025
274ff77
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
jordanstith15 Jan 30, 2025
79ec9ea
chore(lockfile): updating lockfile after syncing with main
jordanstith15 Jan 30, 2025
bae081a
chore(frame-router): refactoring to pass tests, adding tests for quer…
jordanstith15 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/iframe-coordinator/src/elements/frame-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,6 @@ export default class FrameRouterElement extends HTMLElement {
return hostUrlObject.href;
}
const trimmedUrl = stripTrailingSlash(hostUrl);
return window.location.hash ? `${trimmedUrl}/#` : trimmedUrl;
return window.location.hash ? `${trimmedUrl}#` : trimmedUrl;
}
}
Loading