Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactoring hash logic to fix possible issue with query param on host route (i.e. timemachine override) #271

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: refactoring hash logic to fix possible issue with query param on host route (i.e. timemachine override) #271

wants to merge 16 commits into from

Conversation

jordanstith15
Copy link
Collaborator

@jordanstith15 jordanstith15 commented Jul 9, 2024 •
edited by jira bot
Loading

Closes COMUI-1386

@jordanstith15 jordanstith15 requested a review from MattCheely July 9, 2024 13:02
@jordanstith15 jordanstith15 changed the title fix: removing slash to fix possible issue with query param on host route (i.e. timemachine override) fix: refactoring hash logic to fix possible issue with query param on host route (i.e. timemachine override) Nov 6, 2024
@jordanstith15 jordanstith15 marked this pull request as ready for review November 6, 2024 13:24
@MattCheely
Copy link
Collaborator

We should add a unit test that calls setupFrames on a FrameRouter instance and validates that the hostRootUrl property in the generated environment data is constructed as expected, both with and without query parameters in the original URL.

MattCheely and others added 9 commits December 9, 2024 12:01
@MattCheely @jordanstith15
feat(ifc-cli): add support for proxy configuration via a json file
13c6080 
This adds support for ifc-cli proxying specified paths to a local dev server or other server to
enable same-origin hosting features. Proxies are configured via a json file that maps paths to
target URLs.
@jordanstith15
chore(release): 6.1.0
cd15328
@jordanstith15
chore: updating package-lock after syncing with main
cf36ab1
@jordanstith15
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
fe2b77e 
…to feature/COMUI-1386
@jordanstith15
chore(frame-router): simplifying if clause in processHostUrl
8945ffd
@jordanstith15
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
cf19d6b 
…to feature/COMUI-1386
@jordanstith15
chore(ifc-example): changing the hostRootUrl for the example ifc conf…
32b707f 
…igs to reflect irl setups
@jordanstith15
Merge branch 'main' of github.com:purecloudlabs/iframe-coordinator in…
3c39a0e 
…to feature/COMUI-1386
@jordanstith15
chore(ifc-example): updating lockfile after syncing with main
a250811
@MattCheely MattCheely mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattCheely MattCheely Awaiting requested review from MattCheely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanstith15 @MattCheely