Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yosys #86

Open
wants to merge 3 commits into
base: astral
Choose a base branch
from
Open

Fix Yosys #86

wants to merge 3 commits into from

Conversation

belanoa
Copy link

@belanoa belanoa commented Oct 18, 2024

Some small modifications to the code to make it compatible with Yosys

@belanoa belanoa requested a review from yvantor October 18, 2024 13:57
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for temporarily fixing open-source-tools-based design flows, but I think the organization should be changed quite much. For example, most of the defines files that changed name contain defines that became parameters, and in general defines can be exported with Bender without needing to create specific files. I think this was used for integration in a "complete" PULP system (pulp_soc + pulp_cluster), but I think a PULP system could also be updated with a cleaner structure. Long story short, @belanoa before closing this, could you open an issue stating these problems? I would suggest opening it here and in the PULP repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants