Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): add missing sqs service without subservice #6352

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Jan 3, 2025

Context

There is a problem when scanning SQS queues with other ARNs.

fix #6346

Description

Added sqs to service without subservices list.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners January 3, 2025 10:56
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (f1c008f) to head (150b6b5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6352   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files        1182     1182           
  Lines       36315    36315           
=======================================
  Hits        32717    32717           
  Misses       3598     3598           
Flag Coverage Δ
prowler 90.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 90.09% <100.00%> (ø)
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec added backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch labels Jan 6, 2025
@MrCloudSec MrCloudSec merged commit 3d6a6a9 into master Jan 6, 2025
14 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5861-resource-arn-not-working-with-sqs-when-ran-with-another-resource branch January 6, 2025 17:48
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 6, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.6
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource-arn not working with SQS when ran with another resource
3 participants